bitfocus / companion-module-songbeamer-osc

Songbeamer OSC Module
MIT License
5 stars 0 forks source link

presentation state not applied with named params #39

Closed bensteUEM closed 1 year ago

bensteUEM commented 1 year ago
debug: Sent OSC to 192.168.0.28:10023 with /presentation/state and [{"type":"s","value":"logo"}]
debug: Received OSC message from: {"address":"192.168.0.28","family":"IPv4","port":10023,"size":28}
debug: OSC Content is: {"address":"/presentation/state","args":[{"type":"i","value":0}]}
debug: presentation/state 0
debug: Sent OSC to 192.168.0.28:10023 with /presentation/state and [{"type":"s","value":"background"}]
debug: Received OSC message from: {"address":"192.168.0.28","family":"IPv4","port":10023,"size":28}
debug: OSC Content is: {"address":"/presentation/state","args":[{"type":"i","value":0}]}
debug: presentation/state 0

@Lasibian - did you change the required params for presentation states? The code used to work before (but didn't send feedback) Previously it used to be text params now the response seem to be numbers?

Ever since the 6.04 release a number instead of a string state is returned and the text values are not applied.

Lasibian commented 1 year ago

There was a new bug when receiving the string value for an enum item. Will be fixed in the next update.

bensteUEM commented 1 year ago

Also applies to "video_state" #41

Lasibian commented 1 year ago

Please test again in SongBeamer 6.04c. It turned out that the enum values for the state were incorrect. 0 should be stop, 1 = play, 2 = pause for better logic and consistency with live video.

bensteUEM commented 1 year ago

With 6.04c Update neither int nor string change presentation state. Seems to be a regression bug with the API? (even though a response with the correct "updated" state is received ...

bensteUEM commented 1 year ago

update did also break /video/state neither string nor int value is accepted for changes

Lasibian commented 1 year ago

It works fine for me. Please try the demo application from https://download.songbeamer.de/SongBeamer-OSC.zip

bensteUEM commented 1 year ago

I've tried the Demo app you provided with the 6.04c release and even this one sends inconsistent data... (tested for presentation state)

black/background is sent as str e.g. "black" logo is sent as int - 3 page state is missing completely

bensteUEM commented 1 year ago

after restarting songbeamer both demo app and companion module work with presentation state again - looks like Songbeamer somehow ended up in an unstable state not accepting OSC anymore...

bensteUEM commented 1 year ago

/video/state also work!

Lasibian commented 1 year ago

There is indeed a bug that SongBeamer needs to be restarted after activating OSC.

The demo app is inconsistent when sending presentation start. This is intentional, so that both modes get tested.