Combine presentation_language_primary and presentation_language into one action

bitfocus / companion-module-songbeamer-osc

Songbeamer OSC Module

MIT License

6 stars 0 forks source link

Combine presentation_language_primary and presentation_language into one action #6

Open bensteUEM opened 1 year ago

bensteUEM commented 1 year ago

At present both actions are implemented as separate action. Logically both might depend on each other.

This issue is about

Merging both into one single action sending multiple messages (similar to #2 )
Modify the available options to support easier user access
- e.g. Checkbox for each language?
- auto detect primary language based on language order

bensteUEM commented 1 year ago

After combining both actions into one it seems that there is no change applied debug: Sent OSC to 192.168.0.28:10023 with /presentation/primarylanguage and [{"type":"i","value":2}] debug: Sent OSC to 192.168.0.28:10023 with /presentation/language and [{"type":"s","value":"234"}]

bensteUEM commented 1 year ago

tested with 6.04a - no changes in Songbeamer when trying to set primary lanugage or changing language order


system: ** Log cleared **
warn: Songbeamer does not yet act upon the request  - check #6
debug: Sent OSC to 192.168.0.28:10023 with /presentation/primarylanguage and [{"type":"i","value":1}]
debug: Sent OSC to 192.168.0.28:10023 with /presentation/language and [{"type":"s","value":"1234"}]
warn: Songbeamer does not yet act upon the request  - check #6
debug: Sent OSC to 192.168.0.28:10023 with /presentation/primarylanguage and [{"type":"i","value":1}]
debug: Sent OSC to 192.168.0.28:10023 with /presentation/language and [{"type":"s","value":"1234"}]
warn: Songbeamer does not yet act upon the request  - check #6
debug: Sent OSC to 192.168.0.28:10023 with /presentation/primarylanguage and [{"type":"i","value":1}]
debug: Sent OSC to 192.168.0.28:10023 with /presentation/language and [{"type":"s","value":"21"}]

bensteUEM commented 1 month ago

[ ] primary language should not conflict language order
[ ] language order is not applied

bensteUEM commented 1 month ago

Fixes in Songbeamer required

[ ] Primary language is not change when manually selecting a different "show only" language via Songbeamer GUI which differes from primary language (e.g. ##2)
[ ] setting /presentation/languages is not applied in Songbeamer
[ ] /presentation/languages returns "" instead of "ALL" or "1234" in case "All languages" is selected in Songbeamer

I'm unsure how to select e.g. language 3 and 4 only in GUI therefore can not test /presentation/languages

Lasibian commented 1 month ago

Select multiple languages in SongBeamer by holding down Ctrl.

/presentation/languages returns "" for all languages. This is according to the current documentation.