Can't edit the connection settings while connection is inactive

dominik34 commented 7 months ago

Is this a bug in companion itself or a module?

[X] I believe this to be a bug in companion

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug

It is not possible to edit a connection (e.g. change the IP-Address) when the device is not reachable or the connection is disabled.

Do I have to make a new connection rebuild everything I've done?

Steps To Reproduce

Added a new connection (e.g. Soundcraft Ui with IP 192.168.1.10)
Build the Companion interface with all the Buttons accoring to this connection
The IP Adress of the Device (soundcraft Ui) change because of a network change (is now e.g. 192.168.3.x)
Can't update the connection to the new IP-Adress: Loading bar and "connection config unavaliable"

Expected Behavior

No response

Environment

- OS: Windows 10
- Browser: Firefox
- Companion Version: 3.2.0 (+6663)

Additional context

I remember, changing the connection-config was possibel in previous builds.

Julusian commented 7 months ago

This is a bug in the module, it shouldn't be waiting for the connection to open inside of its init method.

There is already an issue for configuring disabled modules bitfocus/companion#2562

dominik34 commented 7 months ago

Thanks for the clarification!

A workaround for anyone facing this issue: Export the config, open the file with a texteditor, search for "soundcraft" and change the IP Adress there. Then import the config again an you'll be fine.

fmalcher commented 7 months ago

Thanks for the report! I will try to fix this next week. However, it will take a bit of time to have this released together with Companion.

bitfocus / companion-module-soundcraft-ui