bitfocus / companion-module-soundcraft-ui

MIT License
15 stars 6 forks source link

Add Fx parameters/BPM controls #93

Closed 100erbe closed 3 weeks ago

100erbe commented 3 weeks ago

Incredible work so far!! After months of tests and research I am finally able to recall scenes and modify the mixer's parameters via MIDI commands thanks to your module. As a performing musician it would be absolutely amazing to have the chance to modify effects parameters or at least BPM value to be able to recall CUES instead of having to recall a snapshot (or show) which results in a 1 second audio dropout in the Soundcraft UI series

Thank you!

fmalcher commented 3 weeks ago

This is pretty funny, since I implemented the functionality for FX params and BPM settings in the upstream connection library just last week 😅 For the companion module, BPM should be a no-brainer, but the FX params are a bit more difficult. We can only control the 6 params generically, without units or scaling. Some effects do not even use all of these params. The values are always between 0 (lowest fader position) and 1 (highest position). That means you will never be able to enter a value like "500 ms" or "2,5 kHz". Do you think it is enough to enter FX param values in companion on a range of 0..100%?

Another thought: Do you also experience dropouts when loading cues? If not, would that be a solution?

100erbe commented 3 weeks ago

First of all, thank you very much for your quick response!

Unfortunately recalling SNAPSHOTS also results in an audio dropout which makes it very annoying and barely usable in a live performance; the only seamless transition possible is using CUES.

As musicians, we hardly need this level of precision for parameters (i.e. having a delay of 500 ms vs 520 ms or a low pass filter on 18500 Hz instead of 20000 Hz on a reverb would be hardly noticeable).

What I'm saying is that the possibility of changing this parameters would be extremely useful for many users that are struggling with the missing MIDI connectivity of this device because with a few tests one could find the right percentage value that works best. Another solution (I have no idea how hard this would be!) could be implement the ability to load FX presets.

Again, thank you for your time and your brilliant work

fmalcher commented 3 weeks ago

add support for saving cues: #94 add support for FX BPM setting: #95 add support for setting FX parameters: #96

fmalcher commented 3 weeks ago

@100erbe This is what I thought about:

Image

fmalcher commented 3 weeks ago

Done! 🥳 This will be part of the next Companion release. If you want to support my work, please consider using GitHub Sponsors to buy me a coffee: https://github.com/sponsors/fmalcher

100erbe commented 3 weeks ago

Thank you, I will definitely buy you a coffee!

Do you have any idea when the release will be out? Will it go along with the next Companion version or how does this go? 🙏

fmalcher commented 3 weeks ago

Exactly! The new module version has been included into Companion yesterday and will be part of the next release. 😊 unfortunately, I have no idea when this will be.

100erbe commented 2 weeks ago

Hi Ferdinand,

Sorry to bother you again! I've just downloaded the latest Companion release (3.4.3) and the Soundcraft module has not been updated yet. Is there any reason for this?

Thanks in advance

fmalcher commented 2 weeks ago

Sorry, I forgot to mention the details ... 🙈 since we added new features, the new module version will be included in the next minor release 3.5.0. Minor releases happen every 3-4 months. But you can install the beta which should have the latest module version onboard.

The Companion team is working on a solution to install modules from file packages. This will simplify the whole process of getting the latest versions.