bitfocus / companion-module-studiocoast-vmix

Studiocoast vMix module for Bitfocus Companion
MIT License
32 stars 10 forks source link

Variable references not parsed in Browser - Navigate #211

Closed tuomastiihonen closed 1 year ago

tuomastiihonen commented 1 year ago

Problem: References to (internal) variables are not replaced by values in the URL of Browser - Navigate.

Steps to reproduce the behaviour:

  1. Add a button with vmix: Browser - Navigate action and enter a browser source as an input (10 in this)
  2. In the vmix: Browser - Navigate action, add a URL with an internal variable like

    https%3A%2F%2F192.168.0.2%2Findex.html%3Fvar%3D$(internal:custom_var)
  3. Companion log shows:

    debug: Sending command: FUNCTION BrowserNavigate Input=10&Value=https%3A%2F%2F192.168.0.2%2Findex.html%3Fvar%3D$(internal:custom_var)

  4. The input properties in vMix also show

    https://192.168.0.2/index.html?var=$(internal:custom_var)

Expected behaviour: The reference to the variable should be replaced by the value of the variable when the action is run.

System:

thedist commented 1 year ago

I'll add this to this to this next update I'm working on,

Please keep in mind though that parsing variables in actions/feedbacks is done on a module by module basis, and has to added to each action/feedback that may need it, so it should not be expected that everything will support that usage, and many modules have no support for it at all.

tuomastiihonen commented 1 year ago

Thanks. I hummed and hawed between bug report and feature request, but ended up with the wrong one :-) I thought I saw a similar report earlier with the feature already pipelined, but couldn't find it now.

thedist commented 1 year ago

Fixed in the latest release