search

bitfocus / companion-module-studiocoast-vmix

Studiocoast vMix module for Bitfocus Companion
MIT License
33 stars 12 forks source link

Cannot update connection IP/port when current connection configuration is timing out #229

Closed morleym closed 10 months ago

morleym commented 1 year ago

Describe the bug When an attempted connection to a vMix TCP ip:port times out, user is unable to effectively edit the connection information in the module.

To Reproduce Steps to reproduce the behaviour:

  1. Go to connection configuration
  2. Enter an ip:port which will time out, and click save on the connection (for example, pointing at the wrong port or attempting to access vMix from outside of a LAN where 'restrict to LAN only' is enabled in vMix settings for the TCP API)
  3. Wait for connection to time out (displayed in log)
  4. Attempt to edit the connection and save the new connection information

Expected behaviour Connection edits are saved, and new attempts to connect are using the updated ip:port

Screenshots image

image

image

System (please complete the following information):

The device running Companion is a desktop PC running Windows. Ample CPU/RAM specs (as opposed to a Pi or low-spec laptop)

image

Additional context The 'save' button is also shown as disabled when I click it. But the connection configuration panel won't open unless you 'enable' the connection, which is the state in which this bug occurs (with information that is timing out)

thedist commented 10 months ago

Some of the retry TCP connection logic has been fixed in the latest version of the module, so this should now be resolved.