bitfocus / companion-module-twitch-api

MIT License
2 stars 3 forks source link

Ad schedule variable and feedback support #18

Open AElfTech opened 11 months ago

AElfTech commented 11 months ago

Describe the feature Support for Twitch Ad Schedule API (https://dev.twitch.tv/docs/api/reference/#get-ad-schedule) through variables and feedback.

Is this version dependent (vMix v24.)? This requires the use of a beta API https://dev.twitch.tv/docs/api/reference/#get-ad-schedule It also requires a new scope channel:read:ads

If documentation is required to implement, do you know where to find it? Twitch API docs https://dev.twitch.tv/docs/api/reference/#get-ad-schedule

Usecases To update button text with next ad countdown time To update button colors, background, etc. based on ad schedule countdown.

(note, I have already implemented all of this and will be submitting a pull request)

AElfTech commented 11 months ago

I just realized there is a problem with the commit that I submitted. It mostly works but there is something going on with the Feedback where it is not updating the values. I need to fix that before this can be merged. I will look into it.

thedist commented 11 months ago

There's already support for this in an upcoming version anyway. There's a lot of things being held off from adding in to the module publicly until they're out of beta, as there are some changes in the works to some beta programs, and there have also been many products that were deprecated before even getting out of beta (Hype chat being one of the latest).

thedist commented 10 months ago

Now that the Ads endpoints are GA, and they've completed their breaking changes to certain fields that got renamed that were known to be coming, I'll be working to get these features implemented as part of the v4.0.0 module update where I'm also implementing DCF, EventSub, and reworking the API requests.