search

bitfocus / companion-module-vbaudio-voicemeeter

MIT License
1 stars 2 forks source link

Fixs and new features #6

Closed PI3RRE01 closed 1 year ago

PI3RRE01 commented 1 year ago

v1.1.2

thedist commented 1 year ago

Because of the v3 deadline in a few days, and the conflicts/issues this PR has while I may be available to test it any merge may not happen until after the v3 launch.

thedist commented 1 year ago

As this PR is reliant on a separate PR for a dependency it really should have been set as a draft to ensure it wouldn't get merged until the other required PR is merged.

The lack of an upgrade script may be a problem but I can add that after this PR is ready if needed.

As I mentioned on the other PR, rather than just random PR's that may interfere with timelines or plans for a module please reach out first, if you find a bug it would be great if you could file an issue, and when doing a PR for those issues/feature requests it can be helpful to do just the fixes in one PR, and features in a separate one so that the bug fixes can easily be merged and updated in Companion instead of requiring all of the other features and dependencies to be reviewed/tested too.

PI3RRE01 commented 1 year ago

Hi,

Thanks for your answer and the time you spend on this development.

I'm novice on github community so forgive me my mistake.

I made this change because I need it for some functionalities and thought it was good idea to share it.

I will close it for now. If you want me to process other way I could

Regards