bitfocus / companion-module-vicreo-hotkey

MIT License
13 stars 7 forks source link

Issue with file paths that have spaces #41

Closed tyler351 closed 2 years ago

tyler351 commented 2 years ago

I'm trying to open a file using the built-in open in the vicreo module. The issue I'm having is the file path has spaces in it and the vicreo app seems to not like the spaces. I've tried a few different thing to see if it helped, such as, formatting it the way that macos terminal would with backslashs in between the words where the spaces are. (/Applecations/Studio\ One\ 5.app). I tried with quotes around everything and with out. I even tried running a shell command but that didnt seem to work either.

The output in the vicreo app is the following:

:04:52 error: Command failed: open /Applications/Studio One 5.app
The files /Applications/Studio, /One, and /5.app do not exist.

What am I missing?

JeffreyDavidsz commented 2 years ago

Version?

tyler351 commented 2 years ago

Whoops. Meant to put that in here.

Companion version is 2.4.1 i believe. Vicreo listener version is 3.0.3

JeffreyDavidsz commented 2 years ago

I think I can see where the issue is but need to test on a mac. could you try a shell action? open "/Applications/Studio One 5.app" So with the " around the path and file

tyler351 commented 2 years ago

Yeah. sure thing. Anything specific I can report back?

JeffreyDavidsz commented 2 years ago

Error message if any is ok

JeffreyDavidsz commented 2 years ago

Did you try it?

tyler351 commented 2 years ago

I'm so sorry. I haven't had a chance to try it yet. I can try it first thing tomorrow.

tyler351 commented 2 years ago

So I ended up having to rebuild the setup that I was using this instance on… the issue seems fixed in the later version of vicreo in conjunction with the latest version of companion.

JeffreyDavidsz commented 2 years ago

Check