bitfocus / companion-module-vicreo-hotkey

MIT License
13 stars 7 forks source link

fix: replace md5 #58

Closed Julusian closed 1 year ago

Julusian commented 1 year ago

the builtin crypto module supports generating md5 hashes, you dont need a npm library to do it in nodejs (you might for clientside still)

JeffreyDavidsz commented 1 year ago

Without const crypto = require('crypto') I'm not able to get the crypto part working. Should we add it to module-base for consistency?

Julusian commented 1 year ago

Oops, yeah I meant to include that line, but it slipped through..

Add it to module-base where? Do we need it there?

JeffreyDavidsz commented 1 year ago

Well it might be a idea if people use the module-base as the generic helper for all included dependencies? maybe a module-dep next to module-base and module-tools?

Julusian commented 1 year ago

How does adding it to module-base help?

There isn't an npm dependency being used, so unless you want to expose a md5() function from module-base I dont think there is anything to put there.

JeffreyDavidsz commented 1 year ago

Yeah that