search

bitfocus / companion-module-videolan-vlc

MIT License
8 stars 11 forks source link

VLC Feedback not working in v3.0 betas #53

Closed davidjoshuaford closed 1 year ago

davidjoshuaford commented 1 year ago

In version 3.0 beta 5746, VLC's feedback no longer works for: 

vlc: Item state
vlc: Loop mode
vlc: Repeat mode
vlc: Shuffle mode
vlc: Full Screen

Thanks!

istnv commented 1 year ago

A quick glance looks like the v2.x to v3.x upgrade conversion does not properly re-configure these for v3 format.

davidjoshuaford commented 1 year ago

Thanks!

One more thing to add which is sort of related to these commands:

vlc: Loop mode
vlc: Repeat mode
vlc: Shuffle mode
vlc: Full Screen

Currently the Actions for the above ONLY toggle states.

It would be a great benefit to have the option to choose the Action to be either Toggle/ On/ Off.

For example, if you have one specific video background that loops for supersource, you want to know for sure that Repeat One is ON. Or, if you're playing a list of videos, you want to know for sure that the Loop or Repeat modes are OFF.

Thanks again! David

istnv commented 1 year ago

I added those options to the update. Still waiting for inclusion. VLC only has toggle commands, but when the feedback was added, the module mostly knows the player state.

davidjoshuaford commented 1 year ago

Thanks John, you're saying that VLC itself doesn't have the options for On/Off, only toggle?

Or that Companion currently just doesn't have On/Off built in?

istnv commented 1 year ago

Both. The VLC API only has a toggle option. The module evolved in pieces around available features in Companion, but I can simulate ON/OFF looking at the feedback status. On/Off is in the waiting update.

davidjoshuaford commented 1 year ago

Interesting! Yes I was wondering if a work around could be checking the current status and then initiating a toggle press or not depending if On or Off was required. Thanks for the explanation.

istnv commented 1 year ago

I also added a true/false to the feedback (color) for triggers/variables. Had to do that in the XAir module, too. While Companion has a 'Set variable on condition', it only responds to true(on), but that leaves no way to turn 'off' the variable. In the beta pipeline is a new test for 'condition not true'. Until then, the VLC feedback now has a false option you can test for. Feedback state -> is false -> yes -> set variable

davidjoshuaford commented 1 year ago

Great, I'll check it out!