search

bitfocus / companion-pi

Bitfocus Companion enables the reasonably priced Elgato Streamdeck to be a professional shotbox surface for an increasing amount of different presentation switchers, video playback software and broadcast equipment.
http://bitfocus.io/companion
MIT License
28 stars 8 forks source link

install.sh fails if previously run or if it did not complete #27

Closed MeestorX closed 1 month ago

MeestorX commented 6 months ago

It tries to add the companion user even if it already exists, and then fails https://github.com/bitfocus/companion-pi/blob/2862fd59d6afaf8987dfc41f70bc2eb7a836efe3/install.sh#L32 This line could be changed to something like: id -u companion &>/dev/null || adduser --disabled-password companion --gecos ""

Also can't clone into the folder if it exists already. https://github.com/bitfocus/companion-pi/blob/2862fd59d6afaf8987dfc41f70bc2eb7a836efe3/install.sh#L48

Maybe add: rm -fr /usr/local/src/companionpi before that line?

Julusian commented 1 month ago

Fixed!

MeestorX commented 1 month ago

Nice. Just need to do the same for satellite now.