search

bitfocus / companion

Bitfocus Companion enables the reasonably priced Elgato Streamdeck and other controllers to be a professional shotbox surface for an increasing amount of different presentation switchers, video playback software and broadcast equipment.
http://bitfocus.io/companion
Other
1.53k stars 498 forks source link

Live update renders of presets buttons as variables/feedbacks change #2158

Open dnmeid opened 1 year ago

dnmeid commented 1 year ago

Is this a bug in companion itself or a module?

Is there an existing issue for this?

Describe the bug

When using a feedback on a bank or a variable on a bank text the bank changes dynamically when the feedback or variable is updated. When this button is provided by a preset and you look at it in the preset section there is no live update. The preview of the button is only updated after reentering the preset category.

Steps To Reproduce

No response

Expected Behavior

The button should refect variable updates and feedbacks also in the preset section

Environment (please complete the following information)

- OS: macOS
- Browser: Firefox
- Companion Version: 2.3.1+4641-dc01ac7c

Additional context

No response

Julusian commented 1 year ago

Im changing this to an enhancement, as I am pretty sure this isnt something that has ever been supported, and its not a simple change.

The basic problem is that the ui asks for a render of a certain preset when it opens the presets panel, and the backend makes no attempt to track anything to update when anything changes. It isnt even using feedbacks in the renders.

I think this is going to be a reasonably complex thing to solve, mostly to run the feedbacks correctly (with subscribe and unsubscribe), and not be running the feedback from every preset in the system all the time.