bitfocus / companion

Bitfocus Companion enables the reasonably priced Elgato Stream Deck and other controllers to be a professional shotbox surface for an increasing amount of different presentation switchers, video playback software and broadcast equipment.
http://bitfocus.io/companion
Other
1.55k stars 502 forks source link

[BUG] 3.2 beta bugs - #2658

Closed davidjoshuaford closed 8 months ago

davidjoshuaford commented 9 months ago

Is this a bug in companion itself or a module?

Is there an existing issue for this?

Describe the bug

A few bugs and recommendations for 3.2:

1. Feedback: "internal: Button: Use another buttons style" doesn't import to 3.2

In Companion 3.1, the feedback could reference the same button on a different page, but this doesn't import into v3.2.

The Feedback either misses the whole page reference, and reverts to "this button", which makes the button black, Or it sets it to text with row and column reference, but misses the page number reference:

Screenshot 2023-11-22 at 9 35 06 AM Screenshot 2023-11-22 at 9 46 53 AM

2. Slow interface

I'm finding emulator and Stream Deck surfaces very slow in 3.2. It fails to load most page buttons. Running 3.2 beta6546, on M1 Max. Curious to know if other people are experiencing this too, since my surfaces were very responsive running 3.1.2 on the same system.

3. Connection Order Jumbled on Import

When a config file is imported, it does not retain the connection order that was exported. The order of the connections appears to be arranged in the order in which they were added/created in the original profile.

The problem is when you have many connections (ie 3 atems, 8 hyperdecks, 6 ptz cameras etc) you want to group these for easy viewing and editing. But currently they are a jumbled mess.

Request1: exported configurations would remember the order of the connections. Request2: even better would be the ability to group connections into folders, and to enable/disable all connections in that folder (like you can with layers in a Photoshop folder).

Screenshot 2023-11-22 at 9 53 16 AM

4. Save Top Bar Preference in Config Export

Currently the setting "Show the topbar on each button. This can be overridden per-button" in the Settings > Buttons is not saved as a preference when a configuration is exported.

For my purposes, I design buttons to use the full 72x72, but I notice many people fail to change this top bar setting on export, resulting in jumbled and even missing text display when pushed off-screen.

It would make importing faster to remember if the top bar was enabled or disabled in the design of the original configuration export.

Screenshot 2023-11-22 at 9 25 58 AM

Also a thank you - I noticed earlier versions of 3.2 had unpredictable resizing of text that would push it offscreen, but it appears now that the original sizes of text in 3.1.2 is now replicated in 3.2 – this is important to avoid a lot of reworking of button text display on large profiles.

Steps To Reproduce

No response

Expected Behavior

No response

Environment (please complete the following information)

- OS: M1 Max Sonoma
- Browser: Chrome
- Companion Version: 3.2 beta6545

Additional context

No response

Julusian commented 9 months ago

1) This is an oversight, some fixup being done for actions wasnt done for feedbacks. I think I have a fix, I need to test it before pushing

2) Well, it is kind of expected to be a bit slower due to the change of how the images are being drawn (4x the previous size) and then downscale then when they are displayed. But after making some fixes the other week nothing has felt slow to me

3) keeping the order should be possible for a full import, I guess a page import might be able to keep the order of the new connections, but place them at the end?
There is an issue to be able to group them into folders already

4) I wouldn't call this a bug, this is simply something we never implemented. The needed info isnt being exported currently

davidjoshuaford commented 9 months ago

Thanks Julian!

I’ll look into my slow surfaces a bit more and try to figure out what’s going on.

  1. Yes, keeping order for the full import, and adding at the end for individual pages would be great
Julusian commented 9 months ago

1 and 3 are now fixed.

I think we have been not including the sort order in exports for a while, but it is included now and will be used if found. If the order is missing, it will sort by label instead, to make it predictable

davidjoshuaford commented 9 months ago

Wonderful, thank you!

Any chance the top bar on/off preference could be saved on export?

davidjoshuaford commented 9 months ago

Adding 2 more v3.2 beta6562 bugs that I've found:

5. Text color often does not import

Examples:

Example of how it should look with original white text:

Screenshot 2023-11-27 at 9 22 23 PM

How it looks when 3.1.1 config file is imported into 3.2 beta6562:

Screenshot 2023-11-27 at 9 25 02 PM

(77/1/3 is an example of missing text; 77/1/2 is an example of text that was missing, but then was manually re-selected as black)

6. All Pages are selected in menu dropdown

Screenshot 2023-11-27 at 9 23 53 PM
Julusian commented 9 months ago

5) can you send me an export of a page which does that? I am not able to reproduce going from 3.1.2 -> beta

6) fixed

davidjoshuaford commented 9 months ago

Thanks - will slack you the config page

Julusian commented 9 months ago

@davidjoshuaford do you have any more info on the slowness?

davidjoshuaford commented 9 months ago

@Julusian Not yet, i've been running my shows on 3.1.2. I'll attempt to transition over to the betas and roadtest it more fully in the coming weeks and will report back if I can identify what I was experiencing.

Julusian commented 8 months ago

I'm going to close this for now, as it isnt tracking any bugs that can be addressed currently. Once you have more details on slowness open a new issue and that can be looked into.

If you still want 4) to be done, could you open a new feature request issue too

davidjoshuaford commented 8 months ago

Sounds good - whatever the slowness was it seems to have gone in the recent builds I was using