bitfocus / companion

Bitfocus Companion enables the reasonably priced Elgato Stream Deck and other controllers to be a professional shotbox surface for an increasing amount of different presentation switchers, video playback software and broadcast equipment.
http://bitfocus.io/companion
Other
1.57k stars 499 forks source link

Allow specifying xy in RossTalk #2759

Closed zmcandee closed 7 months ago

zmcandee commented 7 months ago

Is this a feature relevant to companion itself, and not a module?

Is there an existing issue for this?

Describe the feature

Currently the RossTalk Listener relies on converting old banks into new xy button coordinates. Allow a second format that takes the page/row/column format. Something like:

    const match = data.match(/(CC) (?:([0-9]*)\:([0-9]*)|([0-9]*)\/([0-9]*)\/([0-9]*))/)
...
        if (match.length == 5) {
            const xy = [ parseInt(match[3]), parseInt(match[4]) ]
        } else {
            const xy = oldBankIndexToXY(bank)
            if (!xy) {
                this.logger.warn(`Invalid incoming RossTalk command: ${data}`)
                return
            }
        }

Usecases

The best use case is new setups that don't reference the old button numbers outside of RossTalk only have the page/row/column displayed in the configuration page. This would allow mixing and matching the old (CC <page>:<bank>) with the new (CC <page>/<row>/<column>).

Julusian commented 7 months ago

this is in the betas now