search

bitfocus / companion

Bitfocus Companion enables the reasonably priced Elgato Stream Deck and other controllers to be a professional shotbox surface for an increasing amount of different presentation switchers, video playback software and broadcast equipment.
http://bitfocus.io/companion
Other
1.57k stars 499 forks source link

Some modules fail to start (legacy modules) [BUG] #2763

Closed tpk001 closed 7 months ago

tpk001 commented 7 months ago

Is this a bug in companion itself or a module?

Is there an existing issue for this?

Describe the bug

Some legacy modules stopped loading with the latest 3.3.0 beta [bcdb269b073345d6691ec4757bbca29bd30eefa3]

phillips-hue

system: ** Connection started **
error: node:internal/modules/package_json_reader:92
        throw error;
        ^

SyntaxError: Error parsing /Applications/Companion.app/Contents/Resources/module-legacy/manifests/package.json: Unexpected end of JSON input
    at parse (<anonymous>)
    at read (node:internal/modules/package_json_reader:79:16)
    at readPackage (node:internal/modules/package_json_reader:140:10)
    at readPackageScope (node:internal/modules/package_json_reader:157:19)
    at shouldUseESMLoader (node:internal/modules/run_main:77:15)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:122:24)
    at node:internal/main/run_main_module:28:49 {
  path: '/Applications/Companion.app/Contents/Resources/module-legacy/manifests/package.json'
}

Node.js v18.19.1
system: ** Connection stopped **

magewell-proconvert-decoder

system: ** Connection started **
error: node:internal/modules/package_json_reader:92
        throw error;
        ^

SyntaxError: Error parsing /Applications/Companion.app/Contents/Resources/module-legacy/manifests/package.json: Unexpected end of JSON input
    at parse (<anonymous>)
    at read (node:internal/modules/package_json_reader:79:16)
    at readPackage (node:internal/modules/package_json_reader:140:10)
    at readPackageScope (node:internal/modules/package_json_reader:157:19)
    at shouldUseESMLoader (node:internal/modules/run_main:77:15)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:122:24)
    at node:internal/main/run_main_module:28:49 {
  path: '/Applications/Companion.app/Contents/Resources/module-legacy/manifests/package.json'
}

Node.js v18.19.1
system: ** Connection stopped **

Steps To Reproduce

  1. Install the latest 3.3.0 beta [bcdb269b073345d6691ec4757bbca29bd30eefa3]
  2. Load companion
  3. check the connection status on those modules

Expected Behavior

Legacy modules to load up.

Environment (please complete the following information)

- OS: macOS 13
- Browser: NA
- Companion Version: 3.3.0 beta [bcdb269b073345d6691ec4757bbca29bd30eefa3]

Additional context

This might be due to those legacy modules not updated to version 3.0. Can we please have a workaround from Companion to let them work until they get updated?

Julusian commented 7 months ago

This is fixed in beta 6792