bitfocus / companion

Bitfocus Companion enables the reasonably priced Elgato Stream Deck and other controllers to be a professional shotbox surface for an increasing amount of different presentation switchers, video playback software and broadcast equipment.
http://bitfocus.io/companion
Other
1.57k stars 499 forks source link

[BUG] Companion Trigger based on the "Time of Day" event not working #2791

Open LSCkonamedia opened 6 months ago

LSCkonamedia commented 6 months ago

Is this a bug in companion itself or a module?

Is there an existing issue for this?

Describe the bug

Hello there, I am trying to create a simple trigger based on the time of day. No matter what value I enter (following the hh:mm:ss), nothing happens. I even tried to change the trigger to accomodate for all Time zones (litterally went through all of them ) with no success...

Steps To Reproduce

No response

Expected Behavior

No response

Environment (please complete the following information)

- OS:14.3.1 (23D60)
- Browser:Safari
- Companion Version: 3.2.2

Additional context

No response

LSCkonamedia commented 6 months ago

I have the same problem on at least three different machines running windows, Mac intel, MacM1. Is it because I am based in Hawaii?

Julusian commented 6 months ago

I feel like I read something a while back saying that system timezone wasnt respected, but I'm not 100% sure. Perhaps you could try setting adjusted times?

If that is the case, then this can be flipped to an enhancement, and I can look at how to make the timezone handling be correct without breaking existing configs

LSCkonamedia commented 6 months ago

What do you mean by "Setting adjusted times"? I could not find any settings to change on the companion app... And like I said earlier i tried all 24 hours for the trigger and it did not work. I systematically tried my time zone, then added 1, then 2, all the way to +12 and - 12.

I also tried to use this:

"One condition becoming true" > "internal: Variable: Check boolean expression" > ($(internal:time_hms) == '14:06:10') && ($(internal:date_weekday) == 'Monday') I just want to trigger a simple action on a specific day and time :)

But this did not work either... It works when i test actions, but it does not trigger.

Julusian commented 6 months ago

Sorry, ignore that. I didn't read what you wrote well enough :facepalm:

I'll need to give this a try myself to figure out what is going on and how best to fix it

Julusian commented 6 months ago

I've just had a chance to give this a try myself. If I set my system clock to Honolulu (GMT-10), then I have to put in times in GMT still, but then triggers do fire.

So I don't know what is wrong with your machine to not work. I am testing this on linux, but I don't expect that would impact the results here

Doogiechap commented 5 months ago

I posted this in the Facebook Group but just found this thread. I'm running 3.3.0 on a Pi. My trigger times don't follow AWST (+8) my local time on my Pi. They also don't follow UTC. They run 7 hours after what I enter for my trigger time. The times on my companion log reflect AWST (+8)... Any thoughts why this might be?

Screenshot 2024-04-30 at 3 50 45 PM
nqeldridge commented 4 months ago

I'm seeing a similar issue. I've setup several time based triggers and the log will show that it has fired at the correct time, but nothing actually happens. However, if I press the Test actions button, the expected actions happen without issue.

Doogiechap commented 4 months ago

Just to further add. You can identify the time of your Companion internal clock at the bottom of the list in the Variables Tab. This clock is the time that the triggers currently run off. I can't see how to correct the internal clock to current local time (it differs to the clock set on my Pi) however it's a good point of reference to set you trigger times to operate when desired.