[BUG] "Companion is unable to start" on Windows 10

theomnipex commented 1 month ago

Is this a bug in companion itself or a module?

[X] I believe this to be a bug in companion

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug

We have recently updated to the newest Version of Companion. Rebooted and now when we try to start the application, the message pops up and companion closes. Screenshot 2024-05-27 103351

Steps To Reproduce

Try to run companion
Error message pops-up

Expected Behavior

Companion should start normally as before.

Environment (please complete the following information)

- OS: Windows 10 
- Browser: Microsoft Edge 64-bit
- Companion Version: v3.3.0+6991-stable-b27baf94

Additional context

Find the log attached here companion-2024-05-28.0.log

Julusian commented 1 month ago

This looks to be caused by https://github.com/automation-stack/node-machine-id/issues/56, invoked at https://github.com/bitfocus/companion/blob/main/companion/lib/Data/CloudDatabase.js#L32

So I guess we need some fallback mechanism to handle environments where windows is more locked down

Julusian commented 3 weeks ago

This is fixed in the betas and will be in a 3.3.1 patch release 'soon'

bitfocus / companion