bitfocus / companion

Bitfocus Companion enables the reasonably priced Elgato Streamdeck and other controllers to be a professional shotbox surface for an increasing amount of different presentation switchers, video playback software and broadcast equipment.
http://bitfocus.io/companion
Other
1.46k stars 489 forks source link

[BUG] Button text does not allow white space as 1st or 2nd char of text field #2899

Closed phillipivan closed 2 weeks ago

phillipivan commented 3 weeks ago

Is this a bug in companion itself or a module?

Is there an existing issue for this?

Describe the bug

I can not enter the string I am directly as button text. I can enter it via a variable.

Steps To Reproduce

  1. Create button
  2. Try to enter I am as the button text string
  3. Can create a custom variable and set it to I am and display that on a button
  4. Can create a a button and set the button text string to Ia m image

Left most button is a custom variable. Middle is standard text, can not type ' ' as 2nd char. Right button is standard text., can type ' ' as 3rd char.

Expected Behavior

Allow white space as 1st or 2nd char in button text string.

Environment (please complete the following information)

- OS: Win 10
- Browser: Chrome 120
- Companion Version: 3.4.0 Build 7040 & 3.3.1 Stable

Additional context

No response

dnmeid commented 3 weeks ago

That is not a bug, we strip up to two white spaces at front and end of the button texts intentionally.

dnmeid commented 3 weeks ago

Sorry, closed this too fast. Off course only trailing and leading spaces should be trimmed, not spaces within the string.

Julusian commented 2 weeks ago

This isn't a rendering issue, its a ui issue

Julusian commented 2 weeks ago

this new variable input field has been fiddly, and this was another edge case that needed some special handling