Inherit long push and release by action "internal: Button: Trigger press and release"

bitfocus / companion

Bitfocus Companion enables the reasonably priced Elgato Stream Deck and other controllers to be a professional shotbox surface for an increasing amount of different presentation switchers, video playback software and broadcast equipment.

http://bitfocus.io/companion

Other

1.57k stars 499 forks source link

Inherit long push and release by action "internal: Button: Trigger press and release" #2912

Closed Suenee closed 3 months ago

Suenee commented 3 months ago

Is this a feature relevant to companion itself, and not a module?

[x] I believe this to be a feature for companion, not a module

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the feature

How to pass information about a long press of a button? Two solutions:

the button itself would have the property "INHERIT LONG PUSH/RELEASE" if there was some function INTERNAL: BUTTON: TIRGGER* among the actions
the INTERNAL: BUTTON: TIRGGER* action itself would have an "INHERIT LONG PUSH/RELEASE" switch.

In both cases, activating this option should disable the features associated with DURATION GROUP.

Usecases

I use the STREAM DECK PEDAL, to which I dynamically enter a button (page/row/col) to press from the options on the STREAM DECK.

If the target button supports DURATION GROUP, then dynamic button assignment works only for short press and ignores long press.

Julusian commented 3 months ago

I'm not following what you are asking for here. Are you saying that the INTERNAL: BUTTON: TIRGGER* action that is run when you press the pedal isn't executing long presses as you expect. Or are you saying that it is and you don't want it to be.

If the first, it looks to be working for me if I set a internal: Button: Trigger press in the press actions and a internal: Button: Trigger release in the release actions

Suenee commented 3 months ago

I'm not following what you are asking for here. Are you saying that the INTERNAL: BUTTON: TIRGGER* action that is run when you press the pedal isn't executing long presses as you expect.

Yes I expect, that it will run LONG PRESSES, but it is not.

My left pedal is set on this button,

that is forwarding action on ATEM. Short release means just preview (it works fine). Held for 500ms actions means program (it does not work).

Julusian commented 3 months ago

right yeah so you need to set it up so that the pedal uses separate actions for the press and release

Maybe we could make it be propogated 'automatically' but I don't think that would be simple to do so I don't think is worth the effort when you can already get the same behaviour by adding a release action