bitfocus / companion

Bitfocus Companion enables the reasonably priced Elgato Streamdeck and other controllers to be a professional shotbox surface for an increasing amount of different presentation switchers, video playback software and broadcast equipment.
http://bitfocus.io/companion
Other
1.46k stars 489 forks source link

[BUG] Navigate back in group not working correctly #2915

Open slords opened 2 weeks ago

slords commented 2 weeks ago

Is this a bug in companion itself or a module?

Is there an existing issue for this?

Describe the bug

If you have a group with multiple surfaces and try and navigate through multiple levels of pages the Surface: Set to page going back a page doesn't work if using both surfaces to navigate.

Steps To Reproduce

  1. Create group with multiple surfaces
  2. Create buttons with Surface: Set to page going to different pages (1->2, 2->3, 2->4, 3->5, 4->6)
  3. On each of the sub-pages place a Surface: Set to page with current surface and back

Navigation using a single surface at a time works like it should. However, if you navigate from 1->2 using one surface and then 2->3 on a second surface then the back behaves differently on each surface. One will take you back to the first page and the other will take you back to the previous page.

Also if I change the back to reference the group name instead of current surface nothing happens. I can see the current page variable changes to the previous page but the surfaces don't update where they are pointing.

Expected Behavior

Surface: Set to page pointing to back will work correctly for the group regardless of which surface is used to navigate back.

Surface: Set to page set to back and referencing a group name will change the surfaces in that group.

Environment (please complete the following information)

- OS:
- Browser:
- Companion Version:

Additional context

No response