search

bitfocus / companion

Bitfocus Companion enables the reasonably priced Elgato Stream Deck and other controllers to be a professional shotbox surface for an increasing amount of different presentation switchers, video playback software and broadcast equipment.
http://bitfocus.io/companion
Other
1.6k stars 503 forks source link

[BUG] Connections context menu button not working on MacOS Safari #3109

Closed leonreucher closed 1 hour ago

leonreucher commented 3 hours ago

Is this a bug in companion itself or a module?

Is there an existing issue for this?

Describe the bug

In the connections list, the button on the right with the three dots (for showing logs, etc.) is not working - the context menu is not showing when using Safari - Chrome is working fine.

Image

Steps To Reproduce

No response

Expected Behavior

No response

Environment (please complete the following information)

Additional context

No response

Julusian commented 3 hours ago

What version of macos and safari?

Julusian commented 3 hours ago

Oh, I can reproduce this with macos 15 and 18.0.1 It worked fine in 3.5.0+7486-main-abb30808, but not in 3.5.0+7489-main-305c6db0 So it broke during the changes https://github.com/bitfocus/companion/compare/abb30808...305c6db0

Julusian commented 1 hour ago

This is fixed now

I suspect there are more issues lurking from the change that caused this, but the change had to be done at some point