search

bitfocus / companion

Bitfocus Companion enables the reasonably priced Elgato Stream Deck and other controllers to be a professional shotbox surface for an increasing amount of different presentation switchers, video playback software and broadcast equipment.
http://bitfocus.io/companion
Other
1.62k stars 505 forks source link

[BUG] Variable comparison not operating in trigger #3124

Closed ChrisSW58 closed 2 weeks ago

ChrisSW58 commented 2 weeks ago

Is this a bug in companion itself or a module?

Is there an existing issue for this?

Describe the bug

Image This trigger works as expected in 3.4.2. In 3.5.0 beta version 7529 the trigger does not fire.

Steps To Reproduce

Store current minute Compare current minute to stored minute When not =, action trigger

Expected Behavior

Trigger should operate every minute

Environment (please complete the following information)

Additional context

No response

dnmeid commented 2 weeks ago

I just checked this with the current beta and for me the trigger works as expected. (it does show a different version string because I'm running from git main branch) Image

ChrisSW58 commented 2 weeks ago

I will accept it's closed and have coded around it but it does not explain why the same code runs correctly on 3.4.3 and not the beta. It may come back from someone else.

dnmeid commented 2 weeks ago

It does run correctly on the beta as well.

Julusian commented 2 weeks ago

@ChrisSW58 could you provide an export of a broken trigger? That will help ensure we are testing the same thing you are seeing

ChrisSW58 commented 2 weeks ago

@Julusian - here's the config file. the same config works on 3.4.3, and doesn't on 3.5.0 beta 7529. Top right on page 1 you see the time. Works fine when started.(The triggers are to convert from 4 digit 24 hour to 3/4 night with am/pm). The trigger which does not fire is the one called 'Time-Minute Change'. I've recoded it and it's working, but this is the code which doesn't, so something odd is happening between the 2 releases. Load it into 3.4.3 and it changes with the time correctly. In 3.5.0 it doesn't....something has changed and may cause issues for others. Thanks Julian.

Chris-iMac.local_custom-config_20241027-0917.companionconfig.zip