search

bitfocus / companion

Bitfocus Companion enables the reasonably priced Elgato Stream Deck and other controllers to be a professional shotbox surface for an increasing amount of different presentation switchers, video playback software and broadcast equipment.
http://bitfocus.io/companion
Other
1.62k stars 505 forks source link

[BUG] Companion crash on clicking Developer Settings multiple times #3151

Open ChrisSW58 opened 5 days ago

ChrisSW58 commented 5 days ago

Is this a bug in companion itself or a module?

Is there an existing issue for this?

Describe the bug

If you click on the Companion window, Developer Settings 4 times, Companion crashes stating "Unable to start - Companion is unable to start". in a dialog box.

Interestingly in beta 7569, it crashes with only 3 clicks!

Steps To Reproduce

  1. Click on Show/Hide window to show the Companion Window
  2. Click on the Developer Setting cogwheel 4 times
  3. Companion app crashes as stated above

Expected Behavior

No crash!

Environment (please complete the following information)

- OS:Mac OS Sequoia
- Browser: Safari 18.2
- Companion Version:3.5.0 beta version 7574

Additional context

No response

haakonnessjoen commented 4 days ago

@Julusian maybe add a delay before it can be clicked again? If I guess the reason for this bug correctly :P

ChrisSW58 commented 4 days ago

It's not a major issue but I thought I would raise it in case it is symptomatic of more basic memory management problems or something.

Julusian commented 4 days ago

either a delay, or simply resetting restartCounter to 0 would do it.

I think its simply not tracking that the restart performed when clicking the developer button was an intentional restart, so it gets interpreted as a crash.