search

bitfocus / companion

Bitfocus Companion enables the reasonably priced Elgato Stream Deck and other controllers to be a professional shotbox surface for an increasing amount of different presentation switchers, video playback software and broadcast equipment.
http://bitfocus.io/companion
Other
1.62k stars 504 forks source link

Buttons canvas not showing content on IE11 #810

Closed noquierouser closed 4 years ago

noquierouser commented 5 years ago

Describe the bug Buttons contents are not shown on IE11, desktop or tablet modes. Button actions work, but no labels are seen.

To Reproduce Steps to reproduce the behavior:

  1. Go to Companion IP tablet page.
  2. See error

Desktop (please complete the following information):

Additional context I know this browser is pretty much dead and the whole thing, but I want to repurpose a Surface RT that's collecting dust as a button surface. At least it would get an extended lifetime as an ATEM/OBS/CasparCG button switcher.

JeffreyDavidsz commented 5 years ago

Which version of Companion are you using?

noquierouser commented 5 years ago

Which version of Companion are you using?

Latest stable, 1.3.0 (1a7592b-1203).

noquierouser commented 5 years ago

I've taken a couple of screencaps of how it looks like in both pages. It might have something to do with how is canvas rendered inside the buttons, because the emulator canvas renders the Stream Deck photo properly.

I decided to test this with latest unstable from builds, 2.0.0 (669cec2).

emulator-screencap tablet-screencap

noquierouser commented 5 years ago

Well, I've been researching this thing for a while and, apparently, got down to the problem.

IE11 F12 Dev Tools throws an exception in preview.js at line 5, complaining about ImageData() constructor. According to this answer, Internet Explorer isn't compatible with that constructor, data backed up by MDN web docs.

Now, there seems to be a polyfill for this issue that uses the 3 argument format for the constructor (ImageData(array, width, height)). I don't know if this might help to solve this issue.

haakonnessjoen commented 5 years ago

Why not install chrome on your surface?

noquierouser commented 5 years ago

It's a Surface RT, so it can only run Microsoft Store apps.

Again, if it's deemed as a non-issue it won't hurt to close it. I thought it was worth a shot. :)

Deanbau commented 5 years ago

You could create your own buttons that just link to the HTTP calls (/press/bank/1/2) for a really set in stone work around...

jarodwsams commented 5 years ago

Can you install Edge from the store? If you can, see if that functions for you.

josephdadams commented 4 years ago

@noquierouser this is not something I see getting fixed since it’s an IE problem. Closing due to inactivity and workarounds exist.