search

bitforge-me / beryllium

1 stars 9 forks source link

new datapoints to alarm after threshold is breached for x minutes. #115

Closed eoliveros closed 1 year ago

eoliveros commented 1 year ago

this is so we could try to monitor the datapoints and alarm after x minutes of breaching the threshold.

eoliveros commented 1 year ago

i may need to add more datapoints... do not merge yet

eoliveros commented 1 year ago

i thought i made a comment on friday, but it appears i didnt. The datapoints is already there. just need to adjust the kapacitor scripts and deploy to dashboard. I'll make the changes to dashboard server when this has been merged and deployed to the servers.

eoliveros commented 1 year ago

getting pylint errors... no idea how to fix it.

djpnewton commented 1 year ago

ill need help, not sure how to fix the following issue:

  /home/runner/work/beryllium/beryllium/src/app_core.py:126:47 - error: Argument of type "str | None" cannot be assigned to parameter "__x" of type "ReadableBuffer | str | SupportsInt | SupportsIndex | SupportsTrunc" in function "__new__"
    Type "str | None" cannot be assigned to type "ReadableBuffer | str | SupportsInt | SupportsIndex | SupportsTrunc"
      Type "None" cannot be assigned to type "ReadableBuffer | str | SupportsInt | SupportsIndex | SupportsTrunc"
        Type "None" cannot be assigned to type "str"
        Type "None" cannot be assigned to type "ReadOnlyBuffer"
        Type "None" cannot be assigned to type "bytearray"
        Type "None" cannot be assigned to type "memoryview"
        Type "None" cannot be assigned to type "array[Any]"
        Type "None" cannot be assigned to type "mmap"
    ... (reportGeneralTypeIssues)
  /home/runner/work/beryllium/beryllium/src/app_core.py:127:48 - error: Argument of type "str | None" cannot be assigned to parameter "__x" of type "ReadableBuffer | str | SupportsInt | SupportsIndex | SupportsTrunc" in function "__new__"
    Type "str | None" cannot be assigned to type "ReadableBuffer | str | SupportsInt | SupportsIndex | SupportsTrunc"
      Type "None" cannot be assigned to type "ReadableBuffer | str | SupportsInt | SupportsIndex | SupportsTrunc"
        Type "None" cannot be assigned to type "str"
        Type "None" cannot be assigned to type "ReadOnlyBuffer"
        Type "None" cannot be assigned to type "bytearray"
        Type "None" cannot be assigned to type "memoryview"
        Type "None" cannot be assigned to type "array[Any]"
        Type "None" cannot be assigned to type "mmap"
    ... (reportGeneralTypeIssues)

i think the above issue is caused by the value being set to None even though a default value is configured for variables not set in the env file. will try to push again but this time i want it to not start when the variables are not set. and to continue when the variables are set. wanted to see if the actions error message disappears when the its configured this way.

it might be because there was no default param to the os.getenv function