convert capacity on channel from msat to sat.

bitforge-me / beryllium

1 stars 9 forks source link

convert capacity on channel from msat to sat. #90

Closed eoliveros closed 2 years ago

eoliveros commented 2 years ago

Fixing the issue with capacity on the individual channels from msat to sat.

djpnewton commented 2 years ago

why is lint failing?

eoliveros commented 2 years ago

why is lint failing?

its failing on the api_endpoint. not entirely sure why since i didnt make any changes on the api_endpoint.

djpnewton commented 2 years ago

there is a new version of pyright, I will rerun the test

djpnewton commented 2 years ago

maybe try rebasing to master

eoliveros commented 2 years ago

maybe try rebasing to master

did the following:

git rebase master channel_capacity_fix
git push -f

though i think it might be better to close this PR > git pull upstream master(from master local) > create/checkout the new branch > apply the one line change i did?

Will try that if it doesn't work.

eoliveros commented 2 years ago

after doing a git push -f seems like it worked... i can see the latest master change and then my change at the HEAD.