Closed RezaKargar closed 2 years ago
Do we return the Ok status code in such a scenario?
Do we return the Ok status code in such a scenario?
No, The Api returns 500 Internal Server Error
That's fine, what are you looking for?
Isn't better we let the client know that there is some failure?
It's a UX concern. Let's @maryamhdr decide about this.
When a failure happens during sending email for user confirmation or password reset, the Api does not catch that failure exception in proper way that client knows, so the user is not properly aware of the problem
Let's talk about this issue too 👍🏻
As my talk with @maryamhdr this is not a UX thing,
In exception handling of the DoSignUp
in SignUp.razor.cs we only catch ResourceValidationException
and KnownException and the Email sending failure is an Exception which we do not catch:
I've already discussed this with @msynk We've nothing to do with unknown exceptions in our pages and we only handle specific exceptions in our pages. The remaining exceptions will go through global exception handling and at there, we can show toast for all of them We can also log those exceptions later. @RezaKargar @maryamhdr
So I close this issue
When a failure happens during sending email for user confirmation or password reset, the Api does not catch that failure exception in proper way that client knows, so the user is not properly aware of the problem