bitfoundation / bitplatform

Build all of your apps using what you already know and love ❤️
https://bitplatform.dev
MIT License
1.04k stars 217 forks source link

Redundant customizations of the culture in the `CultureInfoManager` class after updating to .NET 8 in the `AdminPanel` project template #5637

Closed msynk closed 7 months ago

msynk commented 8 months ago

After updating to .NET 8 a lot of changes applied to the culture in the CustomizeCultureInfoForFaCulture method of the CultureInfoManager.cs file is redundant.

the only lines of code that is required now are shown in the following image:

image

the rest of the method body should be completely removed.

this method starts at this line: https://github.com/bitfoundation/bitplatform/blob/fcb83f2c6da2a1b42c792497b39f977426e96917/src/Templates/AdminPanel/Bit.AdminPanel/src/Shared/Infra/CultureInfoManager.cs#L55

msynk commented 7 months ago

resolved!