search

bitgapp / Cursr

KVM - Share Mouse & Keyboard between multiple computers. Custom borders and more!
https://cursr.app
Other
192 stars 4 forks source link

Modifier keys seem sticky or don't get detected properly #82

Open Johnhersh opened 1 month ago

Johnhersh commented 1 month ago

Describe the Bug/Issue

Modifier keys don't get properly detected immediately.

Steps to Reproduce

In Safari I usually use Ctrl+Tab to switch tabs. On the client machine if I hold Ctrl, then press Tab it acts like pressing Tab without Ctrl and selects the url bar, if I keep Ctrl still pressed and press Tab again it actually navigates to the next tab.

So to do Ctrl+Tab I have to do Ctrl+Tab+Tab.

I see similar behavior with shift and cmd for closing tabs or switching between apps. Another example is dragging a file from one folder to another. Usually pressing the Opt button adds a green + icon to show the file will be copied. But I have to press it twice for that to get picked up.

Expected Behavior

It should detect modifier buttons.

Your Environment

Additional Context

Attached log of when this happens:

app.log

ragauskl commented 1 month ago

I tried reproducing the issue and majority of keys work as expected for me, but I'm also doing this on 1.7.3 which I'll be releasing as 'beta' now so I'd suggest enabling 'Early Access' in setting and see if 1.7.3 helps. I can however still semi-reproduce the "Usually pressing the Opt button adds a green + icon to show the file will be copied" one, where the green arrow shows up but disappears as soon as mouse is moved.

Let me know if 1.7.3 will solve this (will be released in next hour or so) or if it will be still an issue, in which case I'll have a look again

Johnhersh commented 1 month ago

I tried this for about a day or so now and it seems to work much better!

The only new issue I have now is that it seems modifier keys are applied on both the host machine and the client. For me I use an IDE (Pycharm) and double-shift brings up a menu. If I have it open on both computers I see the menu open up on both computers.

This is totally not a big deal.

But I haven't seen the keys issue in this version.

ragauskl commented 1 month ago

The 'new' issue may not be so new, Cursr doesn't fully consume certain modifier keys so that the keyboard would still emit correct modified keys. This is a temporary thing until I fully and correctly implement handling the state of keyboard to Cursr.

If original issue does not occur by the time 1.7.3 is released as stable I'll close this issue right after stable release then