bitgapp / eqMac

macOS System-wide Audio Equalizer & Volume Mixer 🎧
https://eqmac.app
Apache License 2.0
5.69k stars 334 forks source link

Feature: Linear Phase EQ #624

Open kylehovey opened 2 years ago

kylehovey commented 2 years ago

Disclaimer: Please go through existing feature requests to avoid creating duplicates. If you found a similar issue please post a comment there. If you are uncertain your issue is related to others then create the issue. Obvious ignorance of this rule might get you blocked from posting new issues. Please tick the box below to show that you have followed the guideline.

Description: I would love to be able to switch between a minimum phase EQ and linear phase. The minimum phase EQ (which I think is what is currently there) affects the phase information in the tracks which can affect imaging negatively for a lot of songs. Linear phase EQ has the downside of pre-ringing, but I think the better imaging response would be worth having as an option. I don't know how hard this would be to add, but if this was added I would absolutely pay for the full version.

User flow & interface: Adding a small dropdown for what type of filter is used for EQ could go either in the Advanced parametric EQ or in the Expert visual EQ.

image

andresbrocco commented 2 years ago

Up on this feature!

elliottmejia commented 2 years ago

The minimum phase EQ (which I think is what is currently there) affects the phase information in the tracks which can affect imaging negatively for a lot of songs.

Audio engineer here! While this is technically true, what is likely more noticable to most is the spacial properties of each band's audio, rather than the phase smearing causing it as you describe. I'm sure you have mastered a few songs yourself but ultimately we forget our ears are trained.

This slight difference doesn't account for pre-ringing and CPU load, which consumers will notice much, much more and likely hate.

I personally wouldn't use linear phase live.

kylehovey commented 2 years ago

@Elliottmeija good point, and the pre-ringing can produce some unwanted artifacts as well. I recently tried out SoundID Reference, which provides a minimum phase, linear, and a mixed EQ that compromises between the two. The app lets you chart the phase response, and the middle filter is actually not that bad in terms of phase distortion while sounding better to my ears in terms of spatialization and imaging for many tracks over the minimum phase EQ.

I realize that sort of compromise is probably very difficult to get right, but it may be a good option here if sufficient developer bandwidth is available.

elliottmejia commented 2 years ago

@kylehovey that's an awesome feature, and I'm impressed that they got it right. Time for some red warning text for sure if this feature is implemented, but the need for it could be mitigated if memory is managed properly.