bithavoc / express-winston

express.js middleware for winstonjs
https://www.npmjs.com/package/express-winston
MIT License
798 stars 186 forks source link

Custom log level for errorLogger #111

Closed djihost closed 8 years ago

rosston commented 8 years ago

Thanks for contribution! This change looks good to me, especially since the request logger already has a level option.

Two things I'd like before merging:

  1. Tests added to cover the new functionality, and the fallback to 'error'
  2. (Ideally) your commits, including tests, squashed down to 1 commit. Otherwise, I'll squash the commits before merging, but then the PR would be "Closed" rather than "Merged".
djihost commented 8 years ago

Added tests and squashed the commits to one.

rosston commented 8 years ago

Excellent! Thanks again!

rosston commented 8 years ago

Released in 1.4.0.