search

bithavoc / express-winston

express.js middleware for winstonjs
https://www.npmjs.com/package/express-winston
MIT License
797 stars 187 forks source link

Supporting full response body logging #120

Closed habmic closed 3 years ago

habmic commented 8 years ago

Adding support for full response body logging provided that fullResponseLog is set to true (default is false) and the responseWhitelist contains the value 'body'. I have also stated the memory impact of buffering the response in memory in the documentation

alisherafat01 commented 6 years ago

why no body merges this to master? is there any problem?

bithavoc commented 6 years ago

@alisherafat01 yeah there were some feedback to take care of, rosston is no longer active in this project, however, if I get the tests fixed I'll merge it.

jacob-israel-turner commented 6 years ago

I'd love to see this merged into master - as of right now, we're using a forked version of express-winston that includes the changes in this PR.

bithavoc commented 6 years ago

We should work on this right after #184 (Winston 3 support)

rosston commented 6 years ago

FYI, #184 has been merged.

bithavoc commented 3 years ago

Unfortunately, this PR seems stable, feel free to re-open or rebase.