search

bithavoc / express-winston

express.js middleware for winstonjs
https://www.npmjs.com/package/express-winston
MIT License
797 stars 187 forks source link

Add dynamicMeta to errorLogger #139

Closed scarlettsteph closed 7 years ago

scarlettsteph commented 7 years ago

Add option to receive dynamic meta when using the errorLogger function. PR related to issue #95

rosston commented 7 years ago

Looks good to me. Can you add tests and docs as well?

Also, any preference on #138 vs #139?

scarlettsteph commented 7 years ago

Ok. Also, there is no code difference between those requests but I will close #138. Thanks for asking 👍

scarlettsteph commented 7 years ago

Hi @rosston, I added the tests and docs. Please let me know if you have questions or suggestions.

rosston commented 7 years ago

Merged and released in 2.2.0. Thanks for doing the work to close #95, @scarlettsteph!

scarlettsteph commented 7 years ago

@rosston, awesome! 🎉 Thank you :D