search

bithavoc / express-winston

express.js middleware for winstonjs
https://www.npmjs.com/package/express-winston
MIT License
797 stars 187 forks source link

Winston 3 compatibility #183

Closed dmichelin closed 6 years ago

dmichelin commented 6 years ago

Added the ability to switch between winston versions by handling the propagated TypeError. Fixes #175

rosston commented 6 years ago

@dmichelin Have you run tests with this change? (Weird that CI didn't run it.) I'm working through getting express-winston compatible with winston@3, and I've got a similarly small diff. But I'm getting quite a few test failures.

bithavoc commented 6 years ago

what sorcery is this LOL I can't see the PR in Travis https://travis-ci.org/bithavoc/express-winston/pull_requests

dmichelin commented 6 years ago

I'm getting a message saying that this isn't an active repo on travis CI, possibly that's the reason?

bithavoc commented 6 years ago

@dmichelin I'm in the process of reactivating it with @rosston via email. peer dependencies are broken, we're working in reactivate-ci branch.

bithavoc commented 6 years ago

@dmichelin it seems to be working again, can you rebase from master? I had to make some changes to dev dependencies in package.json

dmichelin commented 6 years ago

It appears to be working now

bithavoc commented 6 years ago

@rosston you're up 🐰

rosston commented 6 years ago

Not trying to kill this PR, but I have a WIP PR that has a working (on newer node versions) winston@3 implementation here: https://github.com/bithavoc/express-winston/pull/184

dmichelin commented 6 years ago

@rosston I'm actually fine with this PR dying since it seems like your PR is further ahead.