Closed dmichelin closed 6 years ago
@dmichelin Have you run tests with this change? (Weird that CI didn't run it.) I'm working through getting express-winston compatible with winston@3, and I've got a similarly small diff. But I'm getting quite a few test failures.
what sorcery is this LOL I can't see the PR in Travis https://travis-ci.org/bithavoc/express-winston/pull_requests
I'm getting a message saying that this isn't an active repo on travis CI, possibly that's the reason?
@dmichelin I'm in the process of reactivating it with @rosston via email. peer dependencies are broken, we're working in reactivate-ci
branch.
@dmichelin it seems to be working again, can you rebase from master? I had to make some changes to dev dependencies in package.json
It appears to be working now
@rosston you're up 🐰
Not trying to kill this PR, but I have a WIP PR that has a working (on newer node versions) winston@3 implementation here: https://github.com/bithavoc/express-winston/pull/184
@rosston I'm actually fine with this PR dying since it seems like your PR is further ahead.
Added the ability to switch between winston versions by handling the propagated TypeError. Fixes #175