search

bithavoc / express-winston

express.js middleware for winstonjs
https://www.npmjs.com/package/express-winston
MIT License
796 stars 187 forks source link

Support winston 3.x transports and formats #190

Closed crellison closed 5 years ago

crellison commented 5 years ago

In their 3.0.0 release, winston deprecated formatting inside transports. https://github.com/winstonjs/winston/blob/master/UPGRADE-3.0.md#removed-winstontransportsfileconsolehttp-formatting-options

This PR adds formats to the options passed into the express-winston logger and errorLogger.

This package also needs a fresh release of typings to DefinitelyTyped, as it's latest version is not compatible with the current winston release.

adamcohen commented 5 years ago

How's the call for maintainers coming along? Would be great to see this merged

bithavoc commented 5 years ago

@crellison feel free to merge and let me know when you'd like me to publish.

crellison commented 5 years ago

@bithavoc Time to give the people what they want

bithavoc commented 5 years ago

@crellison can you update the changelog in another PR or commit to master?

crellison commented 5 years ago

Yup! I'll do that tonight

bithavoc commented 5 years ago

Once we do that we can merge and Release. good call @rosston

crellison commented 5 years ago

changelog updated