Add missing exceptionToMeta and skip to TypeScript definition

bithavoc / express-winston

express.js middleware for winstonjs

https://www.npmjs.com/package/express-winston

MIT License

796 stars 187 forks source link

Add missing exceptionToMeta and skip to TypeScript definition #234

Closed foxted closed 4 years ago

foxted commented 4 years ago

While using this package with Nest.js, I realized there was no ignoreRoutes option on the errorLogger. However, the exceptionToMeta and skip options are available, but were missing from the TypeScript definition.

[x] Add missing exceptionToMeta and skip from errorLogger options to TypeScript definition
[x] Update express-winston-test.ts file with new options

bithavoc commented 4 years ago

Hey @foxted thanks for the PR.

I don't understand the decision to remove responseField, it's still in use.

foxted commented 4 years ago

I couldn't find it in the errorLogger method and the docs, so I assume it wasn't used anymore. I can totally add that back :)

bithavoc commented 4 years ago

Please add it back and I'll publish the new version ASAP :v:

foxted commented 4 years ago

Done :)

bithavoc commented 4 years ago

Published https://github.com/bithavoc/express-winston/releases/tag/v4.0.3