search

bithavoc / express-winston

express.js middleware for winstonjs
https://www.npmjs.com/package/express-winston
MIT License
797 stars 186 forks source link

Consider using inclusive terms rather than Blacklist/Whitelist #241

Closed dsafanyuk closed 4 years ago

dsafanyuk commented 4 years ago

Would be possible to change the terms blackList/whiteList to allowList/denyList?

Perhaps add an option to use the allow/deny alternative to avoid creating a major release change.

Thanks for your library!

bithavoc commented 4 years ago

Yes of course, thank you for pointing it out. If we don’t get a volunteer before then I'll do it this weekend.

dsafanyuk commented 4 years ago

If you’d like, I can attempt it this weekend!

bithavoc commented 4 years ago

Go ahead @dsafanyuk

bithavoc commented 4 years ago

@dsafanyuk Thank you for posting this, we now have a plan to address it, check #247

lamuertepeluda commented 3 years ago

I personally don't feel this kind of terminology change will help solve any kind of issue, either in this repository or in the world: this will just add some confusion in a place where those terms have nothing to do with racism, nor they share any ethimological roots with racial discriminations.
But if you feel like this kind of fig leafs will help the society in any way, who am I to disagree?

ed6767 commented 3 years ago

So guys, we did it. Racism is no more.

zholmes1 commented 3 years ago

Laughable. And the fact that this is still sitting around over a year later just goes to show the true colors being displayed here. Total empty, fake, virtue signaling nonsense. You all should be ashamed.