search

bithavoc / express-winston

express.js middleware for winstonjs
https://www.npmjs.com/package/express-winston
MIT License
797 stars 186 forks source link

Version 4.0.4 fails Typescript builds #248

Closed PeledYuval closed 4 years ago

PeledYuval commented 4 years ago

When compiling, Typescript emits this error: ../../node_modules/express-winston/index.d.ts(33,2): error TS1036: Statements are not allowed in ambient contexts.

This is due to a bug in this commit: https://github.com/bithavoc/express-winston/commit/a02930b1d80a56fefcf158feafe729ea1ecc9f2c line 33 should not have a semi colon.

I reproduced this and checked the fix. by cloning this repo and running npx typescript.

I am opening a PR to fix this. Also, is it possible to ask to add a Typescript compile check to your CI process? I'm not familiar with it, but I would be glad to help if needed.

bithavoc commented 4 years ago

@PeledYuval please submit the PR and I'll merge right away.

We need a robust typescript testing for our type declaration. sorry about that.

PeledYuval commented 4 years ago

@bithavoc Hey, this is the relevant PR: https://github.com/bithavoc/express-winston/pull/249 No worries about this issue. The open source ecosystem would do much worse if we were afraid to put out code. Thanks for your efforts on this lib!

bithavoc commented 4 years ago

Thanks for spotting and fixing this so quickly, it was a minor version so it should not break anything hehe.

express-winston@4.0.5

PeledYuval commented 4 years ago

@bithavoc My builds are green again :) Thank you for quickly responding and merging!