bithavoc / express-winston

express.js middleware for winstonjs
https://www.npmjs.com/package/express-winston
MIT License
797 stars 186 forks source link

Fix metaField/requestField/responseField types #259

Closed davidgoli closed 3 years ago

davidgoli commented 3 years ago

Addresses https://github.com/bithavoc/express-winston/issues/256

lmeerma commented 3 years ago

When is this going to be merged?

bithavoc commented 3 years ago

the real changes we need to merge I believe are:

 metaField?: string | null;
    requestField?: string | null;
    responseField?: string | null;

I don't know about the rest. I can merge and release if you rebase with only those changes. We can open another issue to address the rest of the base interface refactoring.

lmeerma commented 3 years ago

@bithavoc I agree, my problem would be fixed when only metafield, requestField and responseField are changed.

davidgoli commented 3 years ago

@bithavoc Changes made, please take another look

bithavoc commented 3 years ago

Great, I agree there is some repetition, but we can fix that in another PR. I'm ready to merge, do you want to rebase to squash your commits in a single commit or you want github to do it?

davidgoli commented 3 years ago

@bithavoc done

bithavoc commented 3 years ago

Thank you.

bithavoc commented 3 years ago

Thank you 🙏 express-winston@4.1.0