Closed davidgoli closed 3 years ago
When is this going to be merged?
the real changes we need to merge I believe are:
metaField?: string | null;
requestField?: string | null;
responseField?: string | null;
I don't know about the rest. I can merge and release if you rebase with only those changes. We can open another issue to address the rest of the base interface refactoring.
@bithavoc I agree, my problem would be fixed when only metafield
, requestField
and responseField
are changed.
@bithavoc Changes made, please take another look
Great, I agree there is some repetition, but we can fix that in another PR. I'm ready to merge, do you want to rebase to squash your commits in a single commit or you want github to do it?
@bithavoc done
Thank you.
Thank you 🙏 express-winston@4.1.0
Addresses https://github.com/bithavoc/express-winston/issues/256