bithavoc / express-winston

express.js middleware for winstonjs
https://www.npmjs.com/package/express-winston
MIT License
798 stars 186 forks source link

- Correct issue where response body is in whitelist but there is no content-type header #41

Closed t-d-d closed 9 years ago

t-d-d commented 10 years ago

e.g. a 304 response.

bithavoc commented 9 years ago

Please add a test case.

floatingLomas commented 9 years ago

@t-d-d, you need to rebase master onto your branch, too, to make Travis even run the tests (and pick up anything else new).

bithavoc commented 9 years ago

it's a good feature, we just need a test @t-d-d

bithavoc commented 9 years ago

@t-d-d please squash the commits and add proper testing :smile:

bithavoc commented 9 years ago

@t-d-d any plans to add tests to these changes? They seem to be pretty helpful, we just need test coverage.