search

bithavoc / express-winston

express.js middleware for winstonjs
https://www.npmjs.com/package/express-winston
MIT License
798 stars 186 forks source link

Refactor tests to use mock Express req & res ... #51

Closed floatingLomas closed 9 years ago

floatingLomas commented 9 years ago

...(node-http-mocks) instead of hand-rolled ones, fix ignored routes

bithavoc commented 9 years ago

Something's up with the test

bithavoc commented 9 years ago

LOL, please squash :+1:

floatingLomas commented 9 years ago

I done squarshed it.

floatingLomas commented 9 years ago

I have another thing (#52 fix) to add to this so don't merge it yet.

bithavoc commented 9 years ago

Thanks man, you want me to publish to NPM now?

floatingLomas commented 9 years ago

Sure.

On Thursday, January 15, 2015, Johan Hernandez notifications@github.com wrote:

Thanks man, you want me to publish to NPM now?

— Reply to this email directly or view it on GitHub https://github.com/bithavoc/express-winston/pull/51#issuecomment-70099245 .