search

bithavoc / express-winston

express.js middleware for winstonjs
https://www.npmjs.com/package/express-winston
MIT License
798 stars 186 forks source link

Add Test Coverage #54

Closed floatingLomas closed 9 years ago

floatingLomas commented 9 years ago

I'm pretty sure we're missing coverage on a bunch of code - I know for sure that some of the [white|black]list items are being skipped. Probably a good idea to add some type of coverage mechanism.

I use Mocha and Blanket for most of my projects, so I'm not sure what fits with vows, but I just wanted to put it out there.

bithavoc commented 9 years ago

When I started, vows was the shit. looks pretty outdated now.

Would it be too hard to switch to mocha and blanket? :P

floatingLomas commented 9 years ago

I'll give it a deeper look when I get a chance.

On Thursday, January 15, 2015, Johan Hernandez notifications@github.com wrote:

When I started, vows was the shit. looks pretty outdated now.

Would it be too hard to switch to mocha and blanket? :P

— Reply to this email directly or view it on GitHub https://github.com/bithavoc/express-winston/issues/54#issuecomment-70146524 .

floatingLomas commented 9 years ago

So, blanket requires Node >= 0.8; do we need to retain 0.6 support?

bithavoc commented 9 years ago

Let's drop support for 0.6 With a Major version, 1.0.0

floatingLomas commented 9 years ago

Sounds reasonable. Doesn't look like any of the code coverage tools provide 0.6 support, so can't implement that portion for now.

I think there's probably some additional refactoring and feature-adding that should be done prior to a 1.0.0 though...?