Closed floatingLomas closed 9 years ago
beautiful. we should add something to the Readme warning: Node 0.6 users should semver to EW 0.1.x, Node 0.8 users should semver to EW 1.0.x
Cool. Once we make the 1.0.x switch and ditch 0.6 I'll add the coverage stuff.
Cool. It's supposed to work with IO.js which is Node 1.0 may be we need to add this to the readme from now on?
Travis-CI doesn't support IO.js yet so we can't even test it yet, as per travis-ci/travis-ci#3108. Once that's in place, then it could be added to .travis.yml, tested, then mentioned. Or at least that's how I would approach it.
AFAIK istanbul works fine with Node.js 0.6
question is: do we really need to support an ancient version of Node.js?
@dougwilson, Istanbul looks like it might - it'll depend on whether its dependencies do.
@bithavoc, good question - is there any way to find out from npm about which node or npm versions are being used to install it?
I use it for MySQL coverage on Node.js (https://travis-ci.org/felixge/node-mysql/jobs/47203719) and many other modules that support Node.js 0.6 :)
Oh, haha, I take that back; I do not use it on Node.js 0.6, rather I have an exception that skips running istanbul on Node.js 0.6. Wow, can't believe I forgot that :) Basically I have Travis CI run istanbul for non-0.6 builds, haha.
Interesting... I mean, really, only one of the four versions have to run the coverage tests.
I'll give some thought as to how to implement that - which might be made easier if @dougwilson explains how he does it. :P
No problem :)
So there are two parts:
package.json
(or your test runner of choice) I defined multiple ways of invoking the test suite. Usually one for developer, one for developer running coverage, and one for CI (but the CI and coverage can probably just be one thing). Example: https://github.com/jshttp/mime-db/blob/v1.5.0/package.json#L43-L45Awesome. Thanks. :)
As discussed in #54, coverage will have to wait for removing Node 0.6 support because the coverage tools all require >=0.8
Have a look and let me know what you think - there's no rush on this one. If any other PRs get merged in I'll rebase this to include them.
For what it's worth, coverage is currently at 89%, so not too shabby.