search

bithavoc / express-winston

express.js middleware for winstonjs
https://www.npmjs.com/package/express-winston
MIT License
797 stars 187 forks source link

ignoredRoutes Doesn't Work #63

Closed elsbree closed 9 years ago

elsbree commented 9 years ago

I know the ignoredRoutes property is undocumented, but it doesn't seem to work as currently implemented. It uses req.route, which is apparently only available after requests are handled or in route-specific middleware (according to this Stack Overflow question).

Maybe testing req.url against a regex or an array of strings would work? I'd be happy to submit a PR.

floatingLomas commented 9 years ago

Yes, please do - with tests, please. :)

Thanks!

rbudiharso commented 9 years ago

merge please?

floatingLomas commented 9 years ago

@bithavoc, can you merge this?

floatingLomas commented 9 years ago

...or give me the magic again? :P

floatingLomas commented 9 years ago

@bithavoc, just following up...

katopz commented 6 years ago

So, it still not working? (seem to not working for me atm)