Closed ppitonak closed 9 years ago
LGTM, but @bithavoc or whoever else will have to merge it.
@floatingLomas you have been commiter since forever
I was at one point. I don't currently have write access, or at least that's what the message is telling me...
Ok, I looked it up. :P I had write permissions when this repo was under the firebaseco namespace because I was a part of that group; I'm pretty sure I lost those permissions whenever you moved it into your own namespace.
@floatingLomas fixed, pls ping me when you need npm push
, actually I can give you publishing rights
, what's your NPM user?
@bithavoc, cool. Perhaps not surprisingly, it is floatinglomas. :)
I'll do some PR cleanup in the morning.
@ppitonak, can you rebase the new stuff in bithavoc/express-winston
's master
onto this and re-push it, so I can merge it?
rebased
Thanks for merging, when do you plan to publish release?
Soon as @bithavoc adds me for npm publish
ing. :)
In a few mins
@floatingLomas done, you're the man now.
Awesomo. Published.
Skip
option added with same behavior as in https://github.com/expressjs/morgan. Function to determine if logging is skipped, defaults tofalse
. This function will be called asskip(req, res)
.