bithavoc / express-winston

express.js middleware for winstonjs
https://www.npmjs.com/package/express-winston
MIT License
798 stars 186 forks source link

Skip option added #69

Closed ppitonak closed 9 years ago

ppitonak commented 9 years ago

Skip option added with same behavior as in https://github.com/expressjs/morgan. Function to determine if logging is skipped, defaults to false. This function will be called as skip(req, res).

app.use(expressWinston.logger({
  transports: ...
  skip: function(req, res) { return res.statusCode < 400 }
}));
floatingLomas commented 9 years ago

LGTM, but @bithavoc or whoever else will have to merge it.

bithavoc commented 9 years ago

@floatingLomas you have been commiter since forever

floatingLomas commented 9 years ago

I was at one point. I don't currently have write access, or at least that's what the message is telling me...

floatingLomas commented 9 years ago

Ok, I looked it up. :P I had write permissions when this repo was under the firebaseco namespace because I was a part of that group; I'm pretty sure I lost those permissions whenever you moved it into your own namespace.

bithavoc commented 9 years ago

@floatingLomas fixed, pls ping me when you need npm push, actually I can give you publishing rights, what's your NPM user?

floatingLomas commented 9 years ago

@bithavoc, cool. Perhaps not surprisingly, it is floatinglomas. :)

I'll do some PR cleanup in the morning.

floatingLomas commented 9 years ago

@ppitonak, can you rebase the new stuff in bithavoc/express-winston's master onto this and re-push it, so I can merge it?

ppitonak commented 9 years ago

rebased

ppitonak commented 9 years ago

Thanks for merging, when do you plan to publish release?

floatingLomas commented 9 years ago

Soon as @bithavoc adds me for npm publishing. :)

bithavoc commented 9 years ago

In a few mins

bithavoc commented 9 years ago

@floatingLomas done, you're the man now.

floatingLomas commented 9 years ago

Awesomo. Published.