search

bithavoc / express-winston

express.js middleware for winstonjs
https://www.npmjs.com/package/express-winston
MIT License
798 stars 186 forks source link

Upgrade Winston to 1.0.0 #81

Closed floatingLomas closed 9 years ago

floatingLomas commented 9 years ago

@bithavoc, I finally got around to trying this out (re #74), and everything passes - so either we're cool, or we're missing some tests.

I don't really have time to poke and prod, so maybe we should just call this 0.4.0 and wait for people to start yelling if there's a problem...?

bithavoc commented 9 years ago

No other way to do it

floatingLomas commented 9 years ago

Is that a question or a statement?

bithavoc commented 9 years ago

No, this is what major versions are for, we follow semver.org and everybody who is smart enough to use this library should have added minor or patch revisions wildcards in package.json

What we should do is branch and keep maintaining both 0.3 and 1.0 branches.

How does that sounds?

floatingLomas commented 9 years ago

Sounds great.

bithavoc commented 9 years ago

Allright, let's add instructions to the readme explaining 1.0 and 0.3 requirements and merge this 1.0 branch into master

floatingLomas commented 9 years ago

This make sense?

bithavoc commented 9 years ago

should be: 0.3.x which is our current stable.

newcomers should use our latest 1.0 as this: 1.x

floatingLomas commented 9 years ago

Sooooooo...

Newcomers should start with the latest branch which makes use of winston 1.x.x:

npm install express-winston

If you're already using express-winston, and want to stick with the stable version based on winston 0.9.x, you should instead do:

npm install express-winston@0.3.x

...?

bithavoc commented 9 years ago

yep, like this:

npm install express-winston@0.3.x --save

mathieumg commented 9 years ago

Anything blocking this merge? :) If so, I'd be happy to help! Thanks.

floatingLomas commented 9 years ago

I can't honestly remember. I'll try to find a moment in the next little while to double-check and get back to you.

mathieumg commented 9 years ago

Thanks, no hurry! I just integrated it and since I'm using my own winstonInstance this isn't a showstopper as I thought it would be. Works great, good job! :+1:

floatingLomas commented 9 years ago

I remember what the block was:

I'll try to get this done in the next couple of days.

bithavoc commented 9 years ago

@floatingLomas, any chance you could get this done this week? Otherwise let me know, I'm needing this now.

floatingLomas commented 9 years ago

Done. Sorry for the delay, folks.

@bithavoc, can you change the default Github branch to 1.x instead of master?