search

bither / bither-android

Bither - a simple and secure Bitcoin wallet!
http://bither.net
Apache License 2.0
436 stars 171 forks source link

Feature Request: Import BIP38 encrypted private key in cold wallet #3

Closed dskloet closed 10 years ago

dskloet commented 10 years ago

I think this would be a great use case for Bither. Keep your cold storage encrypted on a paper wallet and when you want to spend it, import it into a cold Bither wallet. Easy to make backups and the keys never touch the internet.

songchenwen commented 10 years ago

We will consider adding BIP38 support in the future. Thanks.

dskloet commented 10 years ago

Actually, I just realized I can't even import a normal private key. I tried to import a private key that I printed from blockchain.info but I was told I have to scan a Bither provided private key. Though I couldn't find any option in Bither to show a private key either.

So an option to import a normal private key would be great as well.

bithernet commented 10 years ago

We only support compressed version of private keys (same as current bitcoind). If blockchain.info use the uncompressed version, Bither are not compatible with that. Maybe in later version, we will consider to support it.

In Bither, you can find advanced private key options with long press the lock icon. :)

dskloet commented 10 years ago

I have now tried scanning a compressed private key but Bither still says

Scan QR code No. 1 provided by Bither

Why does it say "No. 1"? Is it expecting multiple QR codes?

Only when I show the encrypted QR code from Bither, does my other phone act as if it understands the QR code. Then it asks for the encryption password. But then it complains that the passwords are not the same.

inkbus commented 10 years ago

I totally second this request. Adding BIP38 private keys to scan offline paper wallets into cold storage is the missing step in the excellent offline transaction signing feature of Bither.

OR at least Bither should support importing uncompressed private keys, so that one can decode the BIP38 key in Mycelium, and then copy paste the decoded key into Bither.

This is a must!

bithernet commented 10 years ago

Dear @inkbus ,

Currently we are working on BIP38 and uncompressed private keys. We will support these in next version.

Thanks for your advice.

bithernet commented 10 years ago

@dskloet , Sorry for missing your question. When you see "QR Code No.1", that means you are in monitoring function (used to monitor the Bither Cold). You should use the advance option "import private keys". In next version, we will support BIP38 and uncompressed private keys.

Sorry again.

songchenwen commented 10 years ago

Suported this on Bither v1.1.0

dskloet commented 10 years ago

I managed to import a BIP38 key into my cold wallet. Great! But how can I remove the key again after using it?

dskloet commented 10 years ago

By the way, in order to upgrade my cold wallet to 1.1.0, I first uninstalled Bither from my phone before going online. I assumed this would be safe but after installing Bither again it asked me if I wanted to restore a backup it found on the SD card. I found this quite disturbing. I thought there should be any trace of the wallet on the phone while the wallet is online and now I realized the phone was online while at the same time it had a backup of my wallet. So it's not truly cold storage anymore...

There was no money in the wallet so no harm done but I think this should either be different or it should be more obvious what is the proper way to upgrade the offline app.

bithernet commented 10 years ago

@dskloet , Currently Bither does not support removing private keys (it may be dangerous to user's assets), but we are planning to add removing function in the future release in a more safe way.

bithernet commented 10 years ago

@dskloet , Bither Cold will automatically backup the encrypted private keys on the phone's SD card, and in setting page of Bither Cold, you can find backup option there. We design Bither Cold in this way is because that is more simple and secure for normal people, and they can easy have multiple isolated backup devices (you can insert as many SD card as you want, then you will have many backups).

Backup to SD card are only designed for Bither Cold, and it is automatically backup when you add private keys / click backup option / after 1 week without backup and you entering Bither again.

Sorry for the confusing, the better way to upgrade Bither Cold offline (we will try to maintain the compatibility as possible as we can) is :

  1. using a SD card (make sure it is clean and safe) to transfer the new version's apk file;
  2. pairing the Bither Cold phone with another phone in BlueTooth (with the new version's apk file and had been made offline), after transfering the apk file, turn off BlueTooth.
dskloet commented 10 years ago

Thanks for the explanation. You may want to consider that

  1. Many phones don't have a replaceable SD card but only an internal SD card.
  2. When you first use Bither, there is a warning that you should never uninstall it. This suggests that you lose your keys when you uninstall Bither.
  3. The backups feature of Bither doesn't tell you where the backup is saved. I always found this very confusing, as I would think a backup should be external, which it clearly couldn't have been (I have no external SD card).
bithernet commented 10 years ago

@dskloet ,

Thanks for your advice. We will improve these in the future version. :)

dskloet commented 10 years ago

And sorry for all the complaining. You are doing a great job on the app and it's a lot of work.

bithernet commented 10 years ago

@dskloet ,

You have helped us a lot. All your advices are very valuable to our team. Thanks again.

Sincerely,

Wen Hao Bither Team

spongeeluv commented 6 years ago

hello i will be brief.. i created a paper wallet in bitaddress.org. Bip38 is a great invention..even if someone finds your private key they cant sweep it to take the funds without the paraphrase. Now how do we change it back to a private key so we can spend the funds?..and please nobody mention bit2factor.org...they are selling the domain name...im proper depressed i have a lot of bitcoin on a bip38 private key. I have the private key. and the paraphrase .So where do i put this information please?...and do remember all bip38 private keys start with 6p....i wrote this early through the week here goes.....hello my name is mohammed ayyub. I unfortunately have some bitcoin on a private key encrypted with bip38. My Private key is starting with 6P. IF YOU CAN HELP ME I WILL DONATE some bitcoin towards the cause. I also have a website (Bitgangstar.com) promoting bonafide bitcoin info etc. For your help i will give you 1NEEHJLFSdH3hggF77iaMXPAfuoVMuYA4g....(.£41.23) Please check public key in Block chain explorer or any bitcoin website you can check public key status. Status of the key is unspent. You can spend the funds providing you have the private key and Paraphrase. Thank you hope to hear from you soon. I have tried the Bit2factor.org website they are no longer live. They are selling the domain name. ($499.00 usd )...The minute you direct me to the right place i will give you some bitcoin for your time and help

p.s(I'm too embarrassed to tell you how much bitcoin i have on  a previous bip38 encrypted private key address ) boohoo.. :(

bithernet commented 6 years ago

Bither supports BIP38 import

2017-12-20 8:21 GMT+08:00 spongeeluv notifications@github.com:

hello i will be brief.. i created a paper wallet in bitaddress.org. Bip38 is a great invention..even if someone finds your private key they cant sweep it to take the funds without the paraphrase. Now how do we change it back to a private key so we can spend the funds?..and please nobody mention bit2factor.org...they are selling the domain name...im proper depressed i have a lot of bitcoin on a bip38 private key. I have the private key. and the paraphrase .So where do i put this information please?...and do remember all bip38 private keys start with 6p....i wrote this early through the week here goes.....hello my name is mohammed ayyub. I unfortunately have some bitcoin on a private key encrypted with bip38. My Private key is starting with 6P. IF YOU CAN HELP ME I WILL DONATE some bitcoin towards the cause. I also have a website (Bitgangstar.com) promoting bonafide bitcoin info etc. For your help i will give you 1NEEHJLFSdH3hggF77iaMXPAfuoVMuYA4g....(.£41.23) Please check public key in Block chain explorer or any bitcoin website you can check public key status. Status of the key is unspent. You can spend the funds providing you have the private key and Paraphrase. Thank you hope to hear from you soon. I have tried the Bit2factor.org website they are no longer live. They are selling the domain name. ($499.00 usd )...The minute you direct me to the right place i will give you some bitcoin for your time and help

p.s(I'm too embarrassed to tell you how much bitcoin i have on a previous bip38 encrypted private key address ) boohoo.. :(

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/bither/bither-android/issues/3#issuecomment-352927298, or mute the thread https://github.com/notifications/unsubscribe-auth/AF9InLXVBfJpZ6X3EjfxEief6Q2739d9ks5tCFMhgaJpZM4CVr68 .