search

bithost-gmbh / ngx-mat-select-search

Angular component providing an input field for searching / filtering MatSelect options of the Angular Material library.
MIT License
641 stars 129 forks source link

Accessibility Bug #303

Open long2know opened 3 years ago

long2know commented 3 years ago

Currently, when the mat-select w/ ngx-mat-select-search is expanded, the number of items is misreported using NVDA.

In the speech viewer, we see something like this upon expansion:

My list    combo box  collapsed  required  invalid entry  Selection is required
expanded
table
My list
(Item1) - Item1 2 of 49
dropdown search  edit  unavailable  Type to filter list by name  blank

In my test, there are actually (48) items and the initial item selected should be (1 of 48).

Additionally, when the items in the list are filtered, there is no announcement of the number of items that are currently in the list. Comparing to other filterable components, such as material typeahead, the number of items that are available are announced in NVDA.

macjohnny commented 3 years ago

@long2know would you like to improve the accessibility?

the relevant code is located here: https://github.com/bithost-gmbh/ngx-mat-select-search/blob/38a93b3c5911367bf7d002849cfac69be948b638/src/app/mat-select-search/mat-select-search.component.ts#L469-L500