search

bithost-gmbh / pdfviewhelpers

TYPO3 CMS extension that provides various Fluid ViewHelpers to generate PDF documents.
GNU General Public License v3.0
44 stars 19 forks source link

[TASK] Disable tcpdf watermark by default #213

Closed liayn closed 1 year ago

maechler commented 1 year ago

@liayn Closing here in favor of https://github.com/bithost-gmbh/pdfviewhelpers/pull/206 which had no conflicts and an additional feature. Thank you very much nevertheless!

liayn commented 1 year ago

Which is a pity, because by reading it is full of non PSR-2 code quality and so on. :-(

maechler commented 1 year ago

I refactored the code before the release (https://github.com/bithost-gmbh/pdfviewhelpers/commit/19c987d0d9c8e803ff640e209587fa3dc620df2e), but please let me know if you have any concerns regarding this.

liayn commented 1 year ago

Okay. Still we have (boolean) ... in there and stuff like this. => should be (bool) (and no space), for instance. But maybe this should be done in a dedicated cleanup. Thanks for getting this on the road, because I can now drop my fork again ✔

maechler commented 1 year ago

No worries, thank you for the contributions and I agree with the dedicated cleanup 👍